Skip to content

Commit

Permalink
build: move commit message check to be last in pipeline (#29568)
Browse files Browse the repository at this point in the history
It occasionally happens that we get a PR that has both the incorrect commit message and a lint failure. The process of fixing it can take multiple runs, because the author has to fix the commit, re-run and then fix the lint failures.

These changes move the commit message check to be last since if everything else passes, the caretaker can fix the commit message while merging the PR.

(cherry picked from commit 64dfcc0)
  • Loading branch information
crisbeto committed Aug 12, 2024
1 parent 3e83fbb commit ef8e163
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,12 @@ jobs:
run: yarn tslint
- name: Check for circular dependencies
run: yarn -s ts-circular-deps:check
- name: Check commit message
run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}
- name: Check code format
run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}
# Commit message check is last intentionally, because the caretaker can fix it
# during merge, while other lint failures have to be resolved by the PR author.
- name: Check commit message
run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}

api_golden_checks:
runs-on: ubuntu-latest
Expand Down

0 comments on commit ef8e163

Please sign in to comment.