Skip to content

Commit

Permalink
chore: correct comment in in dom-port-host (#1917)
Browse files Browse the repository at this point in the history
  • Loading branch information
jelbourn authored and andrewseguin committed Nov 22, 2016
1 parent 0cf34e2 commit fc30d4c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/lib/core/portal/dom-portal-host.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ export class DomPortalHost extends BasePortalHost {
} else {
componentRef = componentFactory.create(portal.injector || this._defaultInjector);

// ApplicationRef's attachView and detachView methods are in Angular ^2.2.1 but not before.
// The `else` clause here can be removed once 2.2.1 is released.
// ApplicationRef's attachView and detachView methods are in Angular ^2.3.0 but not before.
// The `else` clause here can be removed once 2.3.0 is released.
if ((this._appRef as any)['attachView']) {
(this._appRef as any).attachView(componentRef.hostView);

Expand All @@ -55,7 +55,7 @@ export class DomPortalHost extends BasePortalHost {
} else {
// When creating a component outside of a ViewContainer, we need to manually register
// its ChangeDetector with the application. This API is unfortunately not published
// in Angular <= 2.2.0. The change detector must also be deregistered when the component
// in Angular < 2.3.0. The change detector must also be deregistered when the component
// is destroyed to prevent memory leaks.
let changeDetectorRef = componentRef.changeDetectorRef;
(this._appRef as any).registerChangeDetector(changeDetectorRef);
Expand Down

0 comments on commit fc30d4c

Please sign in to comment.