Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-slide-toggle cannot be styled from outside due to encapsulation #1343

Closed
herkulano opened this issue Sep 27, 2016 · 1 comment · Fixed by #1446
Closed

md-slide-toggle cannot be styled from outside due to encapsulation #1343

herkulano opened this issue Sep 27, 2016 · 1 comment · Fixed by #1446

Comments

@herkulano
Copy link

Bug:

md-slide-toggle has no encapsulation: ViewEncapsulation.None set so it cannot be easily styled from the outside.

What is the expected behavior?

encapsulation: ViewEncapsulation.None should be turn on.
It should be easy to override the component styles

What is the current behavior?

Cannot easily override component style

Which versions of Angular, Material, OS, browsers are affected?

Alpha.9
devversion added a commit to devversion/material2 that referenced this issue Oct 6, 2016
@devversion
fix(slide-toggle): remove view encapsulation
f2944c6 
* Removes the ViewEncapsulation from the slide-toggle component to allow developer overwriting the styles easly.

Fixes angular#1343.
@devversion devversion mentioned this issue Oct 6, 2016
Merged
jelbourn pushed a commit that referenced this issue Oct 18, 2016
@devversion @jelbourn
fix(slide-toggle): remove view encapsulation (#1446)
cbecbce 
* fix(slide-toggle): remove view encapsulation

* Removes the ViewEncapsulation from the slide-toggle component to allow developer overwriting the styles easly.

Fixes #1343.

* Make _hasFocus variable public again for AOT compiler
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slide-toggle): remove view encapsulation devversion/material2
1 participant
@herkulano