Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dialog content elements #1624

Closed
jelbourn opened this issue Oct 27, 2016 · 2 comments · Fixed by #2090
Closed

Add dialog content elements #1624

jelbourn opened this issue Oct 27, 2016 · 2 comments · Fixed by #2090
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@jelbourn
Copy link
Member

jelbourn commented Oct 27, 2016 •
edited
Loading

This will look something like

<!-- user-profile-dialog.html -->
<h3 md-dialog-title>
  User Profile
  <button md-dialog-close></button>
</h3>
<md-dialog-content>
  ...
</md-dialog-content>
<md-dialog-actions>
  <button md-button>SAVE</button>
</md-dialog-actions>
@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Oct 27, 2016
@fxck fxck mentioned this issue Dec 1, 2016
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 6, 2016
@crisbeto
feat(dialog): add dialog content elements
2dfaa9b 
Adds the following dialog-specific directives:
* `md-dialog-close` - Closes the current dialog.
* `md-dialog-title` - Title of a dialog.
* `md-dialog-content` - Scrollable content for a dialog.
* `md-dialog-actions` - Container for the bottom buttons in a dialog.

Fixes angular#1624.
Fixes angular#2042.
@crisbeto crisbeto added the has pr label Dec 6, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 6, 2016
@crisbeto
feat(dialog): add dialog content elements
172824d 
Adds the following dialog-specific directives:
* `md-dialog-close` - Closes the current dialog.
* `md-dialog-title` - Title of a dialog.
* `md-dialog-content` - Scrollable content for a dialog.
* `md-dialog-actions` - Container for the bottom buttons in a dialog.

Fixes angular#1624.
Fixes angular#2042.
@crisbeto crisbeto mentioned this issue Dec 6, 2016
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 14, 2016
@crisbeto
feat(dialog): add dialog content elements
33cb741 
Adds the following dialog-specific directives:
* `md-dialog-close` - Closes the current dialog.
* `md-dialog-title` - Title of a dialog.
* `md-dialog-content` - Scrollable content for a dialog.
* `md-dialog-actions` - Container for the bottom buttons in a dialog.

Fixes angular#1624.
Fixes angular#2042.
jelbourn pushed a commit that referenced this issue Dec 16, 2016
@crisbeto @jelbourn
feat(dialog): add dialog content elements (#2090)
cac72aa 
* feat(dialog): add dialog content elements

Adds the following dialog-specific directives:
* `md-dialog-close` - Closes the current dialog.
* `md-dialog-title` - Title of a dialog.
* `md-dialog-content` - Scrollable content for a dialog.
* `md-dialog-actions` - Container for the bottom buttons in a dialog.

Fixes #1624.
Fixes #2042.

* Rename the dialog directives file.

* Add the selectors for Material 1 compatibility.

* Remove the closeTop method and use the dialogRef instead.

* Add an aria-label to the close button and simplify the testing setup.

* Remove redundant element roles.

* Use the computed value on the dialog title font size.

* Remove the letter spacing override on the dialog title.

* Add a comment regarding the negative bottom margin on the dialog actions.
@michaeljota
Copy link

michaeljota commented Dec 17, 2016 •
edited
Loading

Thanks! 👍

PS: GitHub needs reactions to issues references.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dialog): add dialog content elements crisbeto/material2
3 participants
@jelbourn @crisbeto @michaeljota