Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(MatDialogHarness ): tests from the docs fail #21758

Closed
AlexElin opened this issue Jan 30, 2021 · 2 comments · Fixed by #21759
Closed

bug(MatDialogHarness ): tests from the docs fail #21758

AlexElin opened this issue Jan 30, 2021 · 2 comments · Fixed by #21759
Assignees
@crisbeto
Labels
area: material/dialog area: material/testing docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround

Comments

@AlexElin
Copy link
Contributor

Reproduction

Use StackBlitz to reproduce your issue:

Steps to reproduce:
  1. Open a link to StackBlitz from the docs

Expected Behavior

There're no failed tests

Actual Behavior

Jasmine report shows all (4) tests failed
material

Environment

  • Angular: 11.0.0

  • CDK/Material: 11.0.0

  • Browser(s):

  • Operating System (e.g. Windows, macOS, Ubuntu):
@AlexElin AlexElin added the needs triage This issue needs to be triaged by the team label Jan 30, 2021
@AlexElin AlexElin changed the title bug(MatDialogHarness ): tests from the docs fails bug(MatDialogHarness ): tests from the docs fail Jan 30, 2021
@crisbeto crisbeto self-assigned this Jan 31, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 31, 2021
@crisbeto
build: run example harness unit tests and fix errors
a9d3159 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes angular#21758.
@crisbeto crisbeto mentioned this issue Jan 31, 2021
Merged
@crisbeto crisbeto added area: material/dialog area: material/testing has pr P2 The issue is important to a large percentage of users, with a workaround docs This issue is related to documentation and removed needs triage This issue needs to be triaged by the team labels Jan 31, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 31, 2021
@crisbeto
build: run example harness unit tests and fix errors
a5125c7 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes angular#21758.
@crisbeto
Copy link
Member

crisbeto commented Jan 31, 2021 •
edited
Loading

#21759 will fix the example. In order to get it working for yourself, you have to change line 30 from:

loader = TestbedHarnessEnvironment.loader(fixture);

To the following:

loader = TestbedHarnessEnvironment.documentRootLoader(fixture);

wagnermaciel pushed a commit that referenced this issue Feb 1, 2021
@crisbeto @wagnermaciel
build: run example harness unit tests and fix errors (#21759)
c87506e 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes #21758.

(cherry picked from commit 6947a39)
wagnermaciel pushed a commit that referenced this issue Feb 1, 2021
@crisbeto
build: run example harness unit tests and fix errors (#21759)
6947a39 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes #21758.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Feb 8, 2021
@crisbeto @wagnermaciel
build: run example harness unit tests and fix errors (angular#21759)
b31580d 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes angular#21758.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Feb 8, 2021
@crisbeto @wagnermaciel
build: run example harness unit tests and fix errors (angular#21759)
8093038 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes angular#21758.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/dialog area: material/testing docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: run example harness unit tests and fix errors crisbeto/material2
2 participants
@crisbeto @AlexElin