Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(mat-grid-list): Remove <figure> element from inside mat-grid-tile #21775

Closed
gogitter7 opened this issue Feb 2, 2021 · 2 comments · Fixed by #21826 or livepoll/live-poll#189
Closed
Assignees
Labels
Accessibility This issue is related to accessibility (a11y) area: material/grid-list help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@gogitter7
Copy link

gogitter7 commented Feb 2, 2021

Reproduction

When using the mat-grid-tile element, Angular inserts a "figure" tag on page render. This can cause confusion for screen readers reading aloud the "figure" tag before reading the content inside the tile.

Expected Behavior

Content inside the mat-grid-tile should render as the programmer enters it, rather than inserting a "figure" tag. (If the programmer wishes to surround the content in a figure, they can enter that themselves).

Actual Behavior

The mat-grid-tile component renders a "figure" tag around the ng-content inserted by the programmer, causing unwanted behavior with screen readers.

Environment

  • Angular: 9
  • CDK/Material: 9.2.4
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@gogitter7 gogitter7 added the needs triage This issue needs to be triaged by the team label Feb 2, 2021
@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) area: material/grid-list P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent help wanted The team would appreciate a PR from the community to address this issue and removed needs triage This issue needs to be triaged by the team labels Feb 4, 2021
@crisbeto crisbeto self-assigned this Feb 6, 2021
@crisbeto crisbeto added the has pr label Feb 6, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 6, 2021
Removes the built-in `figure` element inside the grid tile since it isn't always desirable from
an accessibility perspective.

Fixes angular#21775.
@christianruest
Copy link

hey all, i've come accross this issue, as i am facing some problems with the figure element and I saw that the PR was opened and already approved quite some time back, so I wanted to ask about the usual turn-around time of such issue. So by when would you approximately merge the pr?

crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 3, 2021
Removes the built-in `figure` element inside the grid tile since it isn't always desirable from
an accessibility perspective.

Fixes angular#21775.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 4, 2021
Removes the built-in `figure` element inside the grid tile since it isn't always desirable from
an accessibility perspective.

Fixes angular#21775.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 8, 2021
Removes the built-in `figure` element inside the grid tile since it isn't always desirable from
an accessibility perspective.

Fixes angular#21775.
annieyw pushed a commit that referenced this issue Mar 9, 2021
Removes the built-in `figure` element inside the grid tile since it isn't always desirable from
an accessibility perspective.

Fixes #21775.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.