Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MdSidenavlayout should not throw when no MdSidenav is present #269

Closed
jeffbcross opened this issue Apr 6, 2016 · 1 comment · Fixed by #270
Closed

MdSidenavlayout should not throw when no MdSidenav is present #269

jeffbcross opened this issue Apr 6, 2016 · 1 comment · Fixed by #270
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone
alpha.3

Comments

@jeffbcross
Copy link

  • Do you want to request a feature or report a bug?

Bug

  • What is the current behavior?

If I have an MdSidenavLayout without an MdSidenav child, an exception will be raised. For instance, I wanted to avoid pre-compiling sidenav content in a pre-generated html document, so I threw an ngIf on the md-sidenav to hide it, which caused an error.

  • Which version of Angular and Material, and which browser and OS does this issue affect?

Definitely alpha.1, and I think this is still present in alpha.2
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 6, 2016
@jelbourn jelbourn added this to the alpha.3 milestone Apr 6, 2016
hansl added a commit to hansl/material2 that referenced this issue Apr 7, 2016
@hansl
fix: fixes angular#269.
8664ee9
hansl added a commit to hansl/material2 that referenced this issue Apr 7, 2016
@hansl
fix: do not throw when there's no sidenav.
941f9ad 
Fixes angular#269.
@hansl hansl mentioned this issue Apr 7, 2016
Merged
hansl added a commit to hansl/material2 that referenced this issue Apr 7, 2016
@hansl
fix: do not throw when there's no sidenav.
a488238 
Fixes angular#269.
hansl added a commit to hansl/material2 that referenced this issue Apr 7, 2016
@hansl
fix: do not throw when there's no sidenav.
4488ab1 
Fixes angular#269.
hansl added a commit to hansl/material2 that referenced this issue Apr 7, 2016
@hansl
fix: do not throw when there's no sidenav.
d8594ee 
Fixes angular#269.
hansl added a commit to hansl/material2 that referenced this issue Apr 7, 2016
@hansl
fix(sidenav): do not throw when there's no sidenav.
102d0bc 
Fixes angular#269.
jelbourn pushed a commit that referenced this issue Apr 7, 2016
@hansl @jelbourn
fix(sidenav): do not throw when there's no sidenav. (#270)
cc2b223 
Fixes #269.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
alpha.3
Development

Successfully merging a pull request may close this issue.

fix: do not throw when there's no sidenav. hansl/material2
3 participants
@jeffbcross @hansl @jelbourn