fix(sidenav): content jumping in rtl and blurry text on IE #12726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes the content of the sidenav jumping around in RTL if it has active animations. * Fixes text inside the sidenav being blurry on IE and Edge. Relates to angular#10026.
googlebot
added
the
cla: yes
mmalerba
reviewed
Aug 20, 2018
| state('open, open-instant', style({ | ||
| 'transform': 'translate3d(0, 0, 0)', | ||
| 'transform': 'none', |
There was a problem hiding this comment.
Do we know if this was intentionally here to create a compositing layer?
There was a problem hiding this comment.
I don't remember whether it was intentional.
There was a problem hiding this comment.
I traced it waaaay back to here: https://github.com/angular/material2/pull/484/files#diff-6f024e33c78a9c6b2f20c499aef0ac11R20 it appears to have been intentional but there's no explanation of the rationale, so let's just try it and see what happens
mmalerba
approved these changes
Aug 20, 2018
mmalerba
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Fixes the content of the sidenav jumping around in RTL if it has active animations. * Fixes text inside the sidenav being blurry on IE and Edge. Relates to #10026.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #10026.