fix(sidenav): align text at start #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 21, 2016
| @@ -38,6 +38,7 @@ export class MdDuplicatedSidenavError extends MdError { | |||
| template: '<ng-content></ng-content>', | |||
| host: { | |||
| '(transitionend)': '_onTransitionEnd($event)', | |||
| '[attr.align]': 'null' | |||
There was a problem hiding this comment.
Needs comment explaining why this is here.
kara
force-pushed
the
sidenav-align
branch
2 times, most recently
from
f0b20b5
to
237d805
Compare
|
LGTM |
jelbourn
approved these changes
Sep 21, 2016
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 21, 2016
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 22, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End sidenavs were aligning text at "end" because the
align="end"attribute was still on the DOM. This PR removes the attribute so it won't confuse browsers.