fix(radio): update radio group when programmatically uncheck a radio button #1561

tinayuangao · 2016-10-21T20:43:22Z

added test cases for uncheck
notify all radio buttons after status change and radio group value change to avoid notify radio group twice

For issue #609

jelbourn · 2016-10-25T01:10:54Z

src/lib/radio/radio.spec.ts

@@ -216,6 +216,42 @@ describe('MdRadio', () => {

      expect(radioInstances.every(radio => !radio.checked)).toBe(true);
    });
+
+    it('should set radio group to null if uncheck a checked radio button programmatically', () => {


should update the group's selected radio to null when unchecking that radio programmatically

jelbourn · 2016-10-25T01:27:13Z

src/lib/radio/radio.spec.ts

+
+      expect(changeSpy).toHaveBeenCalledTimes(2);
+      expect(groupInstance.value).toBeFalsy();
+      expect(radioInstances.every(radio => !radio.checked)).toBe(true);


Should you also expect(groupInstance.selected).toBeNull() ?

jelbourn · 2016-10-25T01:29:09Z

src/lib/radio/radio.spec.ts

+      expect(radioInstances.every(radio => !radio.checked)).toBe(true);
+    });
+
+    it('should notify the group if check another radio button', () => {


should fire a change event from the group whenever a radio checked state changes

jelbourn · 2016-10-25T01:29:46Z

src/lib/radio/radio.ts

    this._checked = newCheckedState;

    if (newCheckedState && this.radioGroup && this.radioGroup.value != this.value) {
      this.radioGroup.selected = this;
+    } else if (!newCheckedState && this.radioGroup && this.radioGroup.value == this.value) {
+      // For programmatically uncheck radio button, notify the group.


/// When unchecking the selected radio button, update the selected radio // property on the group.

tinayuangao

Comments addressed, PTAL. Thanks!

tinayuangao · 2016-10-25T16:29:22Z

src/lib/radio/radio.spec.ts

+      expect(radioInstances.every(radio => !radio.checked)).toBe(true);
+    });
+
+    it('should notify the group if check another radio button', () => {


tinayuangao · 2016-10-25T16:29:31Z

src/lib/radio/radio.spec.ts

+
+      expect(changeSpy).toHaveBeenCalledTimes(2);
+      expect(groupInstance.value).toBeFalsy();
+      expect(radioInstances.every(radio => !radio.checked)).toBe(true);


tinayuangao · 2016-10-25T16:29:35Z

src/lib/radio/radio.spec.ts

@@ -216,6 +216,42 @@ describe('MdRadio', () => {

      expect(radioInstances.every(radio => !radio.checked)).toBe(true);
    });
+
+    it('should set radio group to null if uncheck a checked radio button programmatically', () => {


tinayuangao · 2016-10-25T16:29:40Z

src/lib/radio/radio.ts

    this._checked = newCheckedState;

    if (newCheckedState && this.radioGroup && this.radioGroup.value != this.value) {
      this.radioGroup.selected = this;
+    } else if (!newCheckedState && this.radioGroup && this.radioGroup.value == this.value) {
+      // For programmatically uncheck radio button, notify the group.


jelbourn · 2016-11-01T00:57:32Z

LGTM

angular-automatic-lock-bot · 2019-09-06T03:01:58Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 21, 2016

tinayuangao added the pr: needs review label Oct 24, 2016

tinayuangao assigned jelbourn Oct 24, 2016

jelbourn reviewed Oct 25, 2016

View reviewed changes

tinayuangao commented Oct 25, 2016

View reviewed changes

tinayuangao force-pushed the unchecked branch 3 times, most recently from 14a235b to cd66748 Compare October 28, 2016 16:37

fix(radio): Uncheck radio group if uncheck radio button programmatically

6cc1981

tinayuangao force-pushed the unchecked branch from cd66748 to 6cc1981 Compare October 31, 2016 17:18

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 1, 2016

hansl merged commit c108607 into angular:master Nov 1, 2016

tinayuangao deleted the unchecked branch November 2, 2016 17:37

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(radio): update radio group when programmatically uncheck a radio button #1561

fix(radio): update radio group when programmatically uncheck a radio button #1561

tinayuangao commented Oct 21, 2016

jelbourn Oct 25, 2016

tinayuangao Oct 25, 2016

jelbourn Oct 25, 2016

tinayuangao Oct 25, 2016

jelbourn Oct 25, 2016

tinayuangao Oct 25, 2016

jelbourn Oct 25, 2016

tinayuangao Oct 25, 2016

tinayuangao left a comment

tinayuangao Oct 25, 2016

tinayuangao Oct 25, 2016

tinayuangao Oct 25, 2016

tinayuangao Oct 25, 2016

jelbourn commented Nov 1, 2016

angular-automatic-lock-bot bot commented Sep 6, 2019

fix(radio): update radio group when programmatically uncheck a radio button #1561

fix(radio): update radio group when programmatically uncheck a radio button #1561

Conversation

tinayuangao commented Oct 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tinayuangao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jelbourn commented Nov 1, 2016

angular-automatic-lock-bot bot commented Sep 6, 2019