Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): raise z-index for overlay-container #1614

Merged
merged 1 commit into from
Oct 26, 2016

Conversation

jelbourn
Copy link
Member

R: @kara
This will help prevent the overlay container from being covered up by other stacking contexts that are directly on the document body.

(of course there's always a higher z-index...)

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2016
@fxck
Copy link
Contributor

fxck commented Oct 26, 2016

I hope this is not a replacement for #1584 (comment)

Otherwise good luck this that https://github.com/search?utf8=%E2%9C%93&q=%22z-index%3A+9999%22&type=Code&ref=searchresults ..

@jelbourn
Copy link
Member Author

Not a replacement, but should generally make things better. Though, I still don't want to remove this z-index in #1584 because it's important that the overlay container always create a new stacking context.

@fxck
Copy link
Contributor

fxck commented Oct 26, 2016

Read the comment. I agree, I proposed moving the custom class from pane to container as well as changing z-indexes similar to what you just did.

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 8f50c35 into angular:master Oct 26, 2016
@jelbourn jelbourn deleted the z-indices branch September 13, 2017 04:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants