Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidenav): transition margin left & right. #1697

Closed
wants to merge 1 commit into from
Closed

fix(sidenav): transition margin left & right. #1697

wants to merge 1 commit into from

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Nov 2, 2016

fixes #1215 #1040

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2016

@mmalerba see #460
We had this in the past but it was rather janky on mobile devices. I'd back-burner this since it's not a major priority for beta.

@jelbourn jelbourn added needs: discussion Further discussion with the team is needed before proceeding and removed pr: needs review labels Nov 3, 2016
@mmalerba mmalerba closed this Nov 3, 2016
@mmalerba mmalerba deleted the snav-anim branch November 18, 2016 00:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jelbourn jelbourn

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement needs: discussion Further discussion with the team is needed before proceeding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"side" mode sidenav doesn't animate content
3 participants
@mmalerba @jelbourn @googlebot