chore(forbidden-identifiers): detect incorrect line endings #1722
Conversation
* Removes stale scope checking (from `@angular2-material/$COMPONENT` times) * Adds support for error grouping (useful when having a file full of invalid line endings) * Moves chains into exta functions to understand procession easily.
googlebot
added
the
cla: yes
| return initialError.fileName === error.fileName && | ||
| initialError.statement === error.statement && | ||
| previousLine === (error.lineNumber - 1); | ||
| } |
There was a problem hiding this comment.
I know this is not very pretty, but we don't have any Lodash helpers here, and this seems to be one elegant approach.
|
@hansl can you take a look? |
|
@hansl Do you have time to take a quick look at this? :) |
|
Hi @devversion, Sorry, this fell off a bit. Looking at it now. |
|
LGTM for now. @devversion What I'd like to see though is moving away from a What do you think? |
|
@hansl - Great idea. I can do a follow-up PR to this one with the custom TS-Lint rules- |
|
Yes, a follow up PR. This one is okay (for now). |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@angular2-material/$COMPONENTtimes)understand procession.