Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): keyboard support #1759

Merged
merged 11 commits into from
Nov 11, 2016
Merged

fix(slider): keyboard support #1759

merged 11 commits into from
Nov 11, 2016

Commits on Nov 10, 2016

  1. fix(slider): refactor the slider to use percent values for the track … 

    …fill and thumb position.
    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    1aa20ac View commit details
    Browse the repository at this point in the history

  2. Addressed comments.

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    1371889 View commit details
    Browse the repository at this point in the history

  3. PercentPipe was adding extra space before '%', so replaced it.

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    c121a84 View commit details
    Browse the repository at this point in the history

  4. remove CommonModule from imports.

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    6c33633 View commit details
    Browse the repository at this point in the history

  5. fix(slider): keyboard support.

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    d457945 View commit details
    Browse the repository at this point in the history

  6. prevent keyboard interaction with disabled slider.

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    7009719 View commit details
    Browse the repository at this point in the history

  7. fix comment

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    d7cafeb View commit details
    Browse the repository at this point in the history

  8. switch to event.keyCode

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    165e5ac View commit details
    Browse the repository at this point in the history

  9. added tests

    @mmalerba
    mmalerba committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    3378c27 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2016

  1. x-browserify keydown event dispatch

    @mmalerba
    mmalerba committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    72fce3f View commit details
    Browse the repository at this point in the history

  2. comment why default: return;

    @mmalerba
    mmalerba committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    cf0e4ca View commit details
    Browse the repository at this point in the history