Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(focus-trap): move template to a separate file #1772

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 8, 2016

Moves the focus trap to a separate file, as per a TODO.

Moves the focus trap to a separate file, as per a TODO.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 8, 2016
@jelbourn
Copy link
Member

@crisbeto does gulp build:release work with this change? I remember there being some reason that the separate template file didn't work for anything in core. (Without I should have written in that comment...)

@crisbeto
Copy link
Member Author

Seems like it does - it didn't throw any errors and the template gets inlined in the dist/@angular/material/material.umd.js, as well as dist/@angular/material/core/a11y/focus-trap.js. Is there anywhere else I should be looking at?

@jelbourn
Copy link
Member

jelbourn commented Nov 12, 2016

I guess it's fine, then

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 12, 2016
@andrewseguin andrewseguin merged commit 8780720 into angular:master Nov 22, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants