Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): Ensure consistent mixedmark rendering across browsers #190

Conversation

traviskaufman
Copy link
Contributor

This commit ensures that the mixedmark renders the same across browsers
by truncating the height of the mixedmark to an integer value.

Fixes #174

This commit ensures that the mixedmark renders the same across browsers
by truncating the height of the mixedmark to an integer value.

Fixes angular#174
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2016
@traviskaufman
Copy link
Contributor Author

@jelbourn updated image diffs:

Chrome:

mdcheckbox-new-chrome

Firefox:

mdcheckbox-new-ff

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn closed this in 666cdba Mar 17, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdCheckbox: Inconsistent mixedmark rendering between Chrome / FF
3 participants