fix(ng-update): properly handle update from different working directory #19934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
fix/properly-handle-ng-update-from-different-working-dir
branch
2 times, most recently
from
d41fd2c to
841ea3a
Compare
devversion
added
merge safe
target: patch
devversion
force-pushed
the
fix/properly-handle-ng-update-from-different-working-dir
branch
from
841ea3a to
ce40cfd
Compare
devversion
added
the
merge: preserve commits
crisbeto
reviewed
Jul 10, 2020
| } | ||
|
|
||
| readDirectory(dirPath: Path): DirectoryEntry { | ||
| const {subdirs: directories, subfiles: files} = this._tree.getDir(dirPath); |
There was a problem hiding this comment.
Not something we control, but it's a little weird for this to be called "sub files" since all files are nested in each other. Maybe we can change it if we're changing other things.
There was a problem hiding this comment.
Yeah, it's definitely a bit ambiguous. You mean that we create a proposal upstream for them to change it?
In some situations, developers will run `ng update` from a sub directory of the project. This currently results in a noop migration as file system paths were computed incorrectly. This is because ng-update always assumed that the CWD is the workspace root in the real file system. This is not the case and therefore threw off path resolution. We fix this by fully relying on the virtual file system now. Previously we mixed virtual and real file system as TypeScript relied on the real file system for parsing configuration, matching and reading files. This commit adds a new compiler host for config parsing and program creation that works fully with a virtual file system. This is something we had planned a long time ago as schematics should never deal with the real file system. We can re-use this logic in other repositories too (such as Angular framework, potentially the CLI, and universal schematics). Ideally we will share this as part of better tooling for migrations. Fixes angular#19779.
…lesheets Previously we globbed the project directory for global stylesheets per target of a project. This is unnecessary and slowing down the update as the project root remains the same across arbitrary targets.
devversion
force-pushed
the
fix/properly-handle-ng-update-from-different-working-dir
branch
from
ce40cfd to
196feda
Compare
|
@crisbeto I've addressed the feedback. Thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, developers will run
ng updatefrom a sub directoryof the project. This currently results in a noop migration as file
system paths were computed incorrectly. This is because ng-update
always assumed that the CWD is the workspace root in the real file
system. This is not the case and therefore threw off path resolution.
We fix this by fully relying on the virtual file system now. Previously
we mixed virtual and real file system as TypeScript relied on the
real file system for parsing configuration, matching and reading files.
This commit adds a new compiler host for config parsing and program
creation that works fully with a virtual file system. This is something
we had planned a long time ago as schematics should never deal with
the real file system. We can re-use this logic in other repositories
too (such as Angular framework, potentially the CLI, and universal
schematics). Ideally we will share this as part of better tooling for
migrations.
Fixes #19779. Resolves COMP-387.