fix(cdk/drag-drop): don't block scrolling if it happens before delay has elapsed #21382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
17923/drag-drop-delay-prevent
branch
from
7f94f2b
to
495bf47
Compare
…has elapsed The `DragRef` has the ability to add a delay to the dragging so that scrolling isn't blocked on touch devices. Currently this doesn't really work, because we always block the native event as a result of a949db3. These changes move some code around so that we only block the events if the item considers itself as being in a "dragged" state (the delay has elapsed and the user is past the drag threshold). Fixes angular#17923.
crisbeto
force-pushed
the
17923/drag-drop-delay-prevent
branch
from
495bf47
to
eb7d3ab
Compare
annieyw
pushed a commit
that referenced
this pull request
Jan 6, 2021
…has elapsed (#21382) The `DragRef` has the ability to add a delay to the dragging so that scrolling isn't blocked on touch devices. Currently this doesn't really work, because we always block the native event as a result of a949db3. These changes move some code around so that we only block the events if the item considers itself as being in a "dragged" state (the delay has elapsed and the user is past the drag threshold). Fixes #17923. (cherry picked from commit eb318d9)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…has elapsed (angular#21382) The `DragRef` has the ability to add a delay to the dragging so that scrolling isn't blocked on touch devices. Currently this doesn't really work, because we always block the native event as a result of a949db3. These changes move some code around so that we only block the events if the item considers itself as being in a "dragged" state (the delay has elapsed and the user is past the drag threshold). Fixes angular#17923.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 30, 2021
In angular#21382 the `preventDefault` call was moved further down so it doesn't prevent events until the dragging threshold has been reached. The problem is that it'll only start calling `preventDefault` from the first event __after__ the threshold has been reached which can be enough time for the device to start scrolling. These changes add an extra call as soon as dragging has been considered as "started". Fixes angular#21749.
This was referenced Jan 30, 2021
annieyw
pushed a commit
that referenced
this pull request
Feb 5, 2021
In #21382 the `preventDefault` call was moved further down so it doesn't prevent events until the dragging threshold has been reached. The problem is that it'll only start calling `preventDefault` from the first event __after__ the threshold has been reached which can be enough time for the device to start scrolling. These changes add an extra call as soon as dragging has been considered as "started". Fixes #21749.
annieyw
pushed a commit
that referenced
this pull request
Feb 5, 2021
In #21382 the `preventDefault` call was moved further down so it doesn't prevent events until the dragging threshold has been reached. The problem is that it'll only start calling `preventDefault` from the first event __after__ the threshold has been reached which can be enough time for the device to start scrolling. These changes add an extra call as soon as dragging has been considered as "started". Fixes #21749. (cherry picked from commit 060ab9e)
annieyw
pushed a commit
that referenced
this pull request
Feb 5, 2021
In #21382 the `preventDefault` call was moved further down so it doesn't prevent events until the dragging threshold has been reached. The problem is that it'll only start calling `preventDefault` from the first event __after__ the threshold has been reached which can be enough time for the device to start scrolling. These changes add an extra call as soon as dragging has been considered as "started". Fixes #21749. (cherry picked from commit 060ab9e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DragRefhas the ability to add a delay to the dragging so that scrolling isn't blocked on touch devices. Currently this doesn't really work, because we always block the native event as a result of a949db3.These changes move some code around so that we only block the events if the item considers itself as being in a "dragged" state (the delay has elapsed and the user is past the drag threshold).
Fixes #17923.