Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(material-experimental/mdc-select): de-duplicate test harness logic #21460

Merged
merged 1 commit into from
Jan 25, 2021
Merged

refactor(material-experimental/mdc-select): de-duplicate test harness logic #21460

merged 1 commit into from
Jan 25, 2021

Conversation

crisbeto
Copy link
Member

Reworks the MatSelectHarness in order to de-duplicate the logic between the base and MDC implementations.

@crisbeto
refactor(material-experimental/mdc-select): de-duplicate test harness…
55ce93b 
… logic

Reworks the `MatSelectHarness` in order to de-duplicate the logic between the base and
MDC implementations.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 28, 2020
@crisbeto crisbeto requested a review from a team as a code owner December 28, 2020 13:15
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2020
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 19, 2021
mmalerba
mmalerba approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit abdc4a0 into angular:master Jan 25, 2021
andrewseguin pushed a commit that referenced this pull request Jan 25, 2021
@crisbeto @andrewseguin
refactor(material-experimental/mdc-select): de-duplicate test harness…
576e694 
… logic (#21460)

Reworks the `MatSelectHarness` in order to de-duplicate the logic between the base and
MDC implementations.

(cherry picked from commit abdc4a0)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 26, 2021
@crisbeto @wagnermaciel
refactor(material-experimental/mdc-select): de-duplicate test harness…
3393458 
… logic (angular#21460)

Reworks the `MatSelectHarness` in order to de-duplicate the logic between the base and
MDC implementations.
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 29, 2021
@crisbeto @mmalerba
refactor(material-experimental/mdc-select): de-duplicate test harness…
b32b78b 
… logic (angular#21460)

Reworks the `MatSelectHarness` in order to de-duplicate the logic between the base and
MDC implementations.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
refactor(material-experimental/mdc-select): de-duplicate test harness…
50973e9 
… logic (angular#21460)

Reworks the `MatSelectHarness` in order to de-duplicate the logic between the base and
MDC implementations.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
refactor(material-experimental/mdc-select): de-duplicate test harness…
b0d9e81 
… logic (angular#21460)

Reworks the `MatSelectHarness` in order to de-duplicate the logic between the base and
MDC implementations.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @andrewseguin