New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(material/theming): normalize config in all typography mixins #21778

Closed

mmalerba wants to merge 7 commits into angular:master from mmalerba:typog-norm

Contributor

mmalerba commented Feb 2, 2021 •

edited

Loading

CARETAKER NOTE: We should update our internal gmat gallery to use the mdc config for all components as well when we sync this

mmalerba added the target: patch label

mmalerba assigned jelbourn and andrewseguin

mmalerba requested review from andrewseguin, crisbeto, devversion, jelbourn and a team as code owners

February 2, 2021 21:53

google-cla bot added the cla: yes label

mmalerba added the merge: caretaker note label

jelbourn approved these changes

View reviewed changes

Member

jelbourn left a comment

overall looks good once you figure out the ci

Contributor Author

mmalerba commented Feb 3, 2021

CI looks good now

mmalerba added action: merge P2 labels

mmalerba force-pushed the typog-norm branch from c4ff327 to af695e4 Compare

February 4, 2021 21:48

mmalerba force-pushed the typog-norm branch from af695e4 to 9883d8a Compare

February 12, 2021 04:40

mmalerba added 6 commits

February 17, 2021 13:42


          refactor(material/theming): normalize config in all typography mixins

eea4c25


          refactor(material/theming): clean up theme file and use mdc typograph…

19dc046

…y everywhere


          fixup! refactor(material/theming): normalize config in all typography…

fde5ec6

… mixins


          fixup! refactor(material/theming): clean up theme file and use mdc ty…

b62d695

…pography everywhere


          fixup! refactor(material/theming): clean up theme file and use mdc ty…

31a60b4

…pography everywhere


          fixup! refactor(material/theming): clean up theme file and use mdc ty…

d008fb6

…pography everywhere

mmalerba force-pushed the typog-norm branch from 9883d8a to d008fb6 Compare

February 17, 2021 21:53


          fixup! refactor(material/theming): clean up theme file and use mdc ty…

79f067e

…pography everywhere

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

8353d9e

for mdc components

This is split off of angular#21778 which covers non-MDC conmponents as well

mmalerba mentioned this pull request

refactor(material/theming): normalize config in all typography mixins for mdc components #21935

Merged

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

690169a

for non-mdc components

This is split off of angular#21778 which covers MDC conmponents as well

mmalerba mentioned this pull request

refactor(material/theming): normalize config in all typography mixins for non-mdc components #21937

Merged

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

f5a8190

for mdc components

This is split off of angular#21778 which covers non-MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

f99b9ee

for non-mdc components

This is split off of angular#21778 which covers MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

7b7993b

for mdc components

This is split off of angular#21778 which covers non-MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

f143f1c

for mdc components

This is split off of angular#21778 which covers non-MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

2b7ddd0

for mdc components

This is split off of angular#21778 which covers non-MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

bf207b1

for non-mdc components

This is split off of angular#21778 which covers MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

c599f56

for non-mdc components

This is split off of angular#21778 which covers MDC conmponents as well

UNDO THIS COMMIT

UNDO THIS COMMIT

UNDO THIS COMMIT

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

0cef8b0

for non-mdc components

This is split off of angular#21778 which covers MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

a8b2cef

for non-mdc components

This is split off of angular#21778 which covers MDC conmponents as well

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

a608a2f

for mdc components

This is split off of angular#21778 which covers non-MDC conmponents as well

andrewseguin pushed a commit that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins (…

c34511e

…#21937)

for non-mdc components

This is split off of #21778 which covers MDC conmponents as well

Contributor Author

mmalerba commented Feb 25, 2021

Closing this one in favor for the split out PRs for MDC and non-MDC components

mmalerba closed this

mmalerba added a commit to mmalerba/components that referenced this pull request


          refactor(material/theming): normalize config in all typography mixins

99b3dc8

for mdc components

This is split off of angular#21778 which covers non-MDC conmponents as well

angular-automatic-lock-bot bot commented Mar 28, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge cla: yes merge: caretaker note P2 target: patch