feat(cdk/drag-drop): allow for preview container to be customized #21830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we always insert the drag preview at the `body`, because it allows us to avoid dealing with `overflow` and `z-index`. The problem is that it doesn't allow the preview to retain its inherited styles. These changes add a new input which allows the consumer to configure the place into which the preview will be inserted. Fixes angular#13288.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Feb 8, 2021
| @@ -43,4 +43,5 @@ export interface DragDropConfig extends Partial<DragRefConfig> { | |||
| listAutoScrollDisabled?: boolean; | |||
| listOrientation?: DropListOrientation; | |||
| zIndex?: number; | |||
| previewContainer?: 'global' | 'parent'; | |||
There was a problem hiding this comment.
Why isn't this option type PreviewContainer?
There was a problem hiding this comment.
This is the interface for the global config object. It didn't seem like an HTMLElement would make sense there, given that it's configured before the app is initialized.
This was referenced Mar 11, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always insert the drag preview at the
body, because it allows us to avoid dealing withoverflowandz-index. The problem is that it doesn't allow the preview to retain its inherited styles.These changes add a new input which allows the consumer to configure the place into which the preview will be inserted.
Fixes #13288.