build: update to latest jasmine and resolve errors #21841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
jasmine-3.6-update
branch
from
068ced2
to
43a40b4
Compare
crisbeto
added
merge safe
P3
josephperrott
requested changes
Feb 8, 2021
package.json
Outdated
| @@ -100,7 +100,7 @@ | |||
| "@types/glob": "^7.1.3", | |||
| "@types/gulp": "4.0.8", | |||
| "@types/inquirer": "^7.3.1", | |||
| "@types/jasmine": "^3.5.4", | |||
| "@types/jasmine": "^3.6.3", | |||
There was a problem hiding this comment.
Can we have our @types/jasmine and and jasmine versions match?
There was a problem hiding this comment.
Done, although there's nothing actually keeping them in sync on npm.
There was a problem hiding this comment.
Oh interesting, I was under the understanding they were in lockstep.
Updates to the latest version of Jasmine and fixes some lint failures.
crisbeto
force-pushed
the
jasmine-3.6-update
branch
from
43a40b4
to
6c5c617
Compare
mmalerba
pushed a commit
that referenced
this pull request
Feb 12, 2021
Updates to the latest version of Jasmine and fixes some lint failures. (cherry picked from commit e7b604f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest version of Jasmine and fixes some lint failures.