Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix test failures and add missing tests #21850

Merged
merged 1 commit into from
Feb 9, 2021
Merged

build: fix test failures and add missing tests #21850

merged 1 commit into from
Feb 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 9, 2021 •
edited
Loading

Fixes some CI issues which were caused by older PRs being merged. The PRs were opened before we had the extra checks for MDC.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 9, 2021
@crisbeto
build: fix test failures and add missing tests
5946f96 
Fixes some CI issues which were caused by older PRs being merged. The PRs were opened,
before we had the extra checks for MDC.
@crisbeto crisbeto marked this pull request as ready for review February 9, 2021 17:21
@crisbeto crisbeto added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Feb 9, 2021
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Feb 9, 2021
@annieyw annieyw merged commit 0930dc3 into angular:master Feb 9, 2021
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
build: fix test failures and add missing tests (#21850)
ddbcda2 
Fixes some CI issues which were caused by older PRs being merged. The PRs were opened,
before we had the extra checks for MDC.

(cherry picked from commit 0930dc3)
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
build: fix test failures and add missing tests (#21850)
5fcb47a 
Fixes some CI issues which were caused by older PRs being merged. The PRs were opened,
before we had the extra checks for MDC.

(cherry picked from commit 0930dc3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @annieyw