Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/overlay): not setting correct opacity in high contrast mode on Firefox #21896

Merged

Conversation

crisbeto
Copy link
Member

The backdrop styles were never switches to the cdk-high-contrast mixin which means that they won't work on Firefox. These changes switch to using the mixin and update the docs.

Fixes #21890.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Feb 13, 2021
@crisbeto crisbeto requested review from jelbourn and a team as code owners February 13, 2021 13:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 13, 2021
…n Firefox

The backdrop styles were never switches to the `cdk-high-contrast` mixin which means that
they won't work on Firefox. These changes switch to using the mixin and update the docs.

Fixes angular#21890.
@crisbeto crisbeto force-pushed the 21890/background-high-contrast-firefox branch from fcf7ea3 to c457d18 Compare February 13, 2021 13:33
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 16, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 4b8427e into angular:master Feb 18, 2021
andrewseguin pushed a commit that referenced this pull request Feb 18, 2021
…n Firefox (#21896)

The backdrop styles were never switches to the `cdk-high-contrast` mixin which means that
they won't work on Firefox. These changes switch to using the mixin and update the docs.

Fixes #21890.

(cherry picked from commit 4b8427e)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Feb 26, 2021
… shorthand path

Fixes a regression caused by angular#21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
wagnermaciel pushed a commit that referenced this pull request Mar 2, 2021
… shorthand path (#22043)

Fixes a regression caused by #21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Mar 2, 2021
… shorthand path (angular#22043)

Fixes a regression caused by angular#21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
wagnermaciel added a commit that referenced this pull request Mar 2, 2021
… shorthand path (#22043) (#22086)

Fixes a regression caused by #21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.

Co-authored-by: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cdk-overlay-dark-backdrop): Is solid black in Windows high contrast dark mode
4 participants