Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update mdc_snapshot_test_cronjob to yarn install before bazel setup #21980

Merged
merged 1 commit into from
Feb 22, 2021
Merged

build: update mdc_snapshot_test_cronjob to yarn install before bazel setup #21980

merged 1 commit into from
Feb 22, 2021

Conversation

josephperrott
Copy link
Member

The mdc_snapshot_test_cronjob needs to yarn install to ensure
that the bazel binary is available before attempting to reference it.

@josephperrott
build: update mdc_snapshot_test_cronjob to yarn install before bazel …
a444577 
…setup

The mdc_snapshot_test_cronjob needs to yarn install to ensure
that the bazel binary is available before attempting to reference it.
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Feb 22, 2021
@josephperrott josephperrott requested a review from a team as a code owner February 22, 2021 21:26
@josephperrott josephperrott removed the request for review from a team February 22, 2021 21:26
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 22, 2021
crisbeto
crisbeto approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 0e6bbb5 into angular:master Feb 22, 2021
andrewseguin pushed a commit that referenced this pull request Feb 22, 2021
@josephperrott @andrewseguin
build: update mdc_snapshot_test_cronjob to yarn install before bazel …
c0149eb 
…setup (#21980)

The mdc_snapshot_test_cronjob needs to yarn install to ensure
that the bazel binary is available before attempting to reference it.

(cherry picked from commit 0e6bbb5)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephperrott @crisbeto @andrewseguin