Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/list): add command+A for MacOs "select all" functionality. #24788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(material/list): add command+A for MacOs "select all" functionality. #24788

wants to merge 1 commit into from
+164 −1

Conversation

volvachev
Copy link
Contributor

Fixes a bug in Angular Material list when using MacOs command+a does not work for 'select all functionality'.

Fixes #24781

@andrewseguin
Copy link
Contributor

Can you add this behavior to the tests and also make the change in the MDC version? This selection list will soon be replaced by the MDC version

@volvachev volvachev force-pushed the fix-selection-list-by-command-with-a branch from 2071e6c to 503e0eb Compare April 16, 2022 07:47
@volvachev volvachev mentioned this pull request Apr 16, 2022
Open
@volvachev
Copy link
Contributor Author

volvachev commented Apr 16, 2022 •
edited
Loading

Can you add this behavior to the tests and also make the change in the MDC version? This selection list will soon be replaced by the MDC version

Hi, I added tests and create pr inside material component web (see material-components/#7591). Do we have to wait for the pr merged in material-components-web?

@volvachev
fix(material/list): add command+A for MacOs "select all" functionality.
a9be4a6 
Fixes a bug in Angular Material `list` when using MacOs `command`+`a` does not work for 'select all functionality'.

Fixes angular#24781
@volvachev volvachev force-pushed the fix-selection-list-by-command-with-a branch from 503e0eb to a9be4a6 Compare April 16, 2022 08:01
@volvachev volvachev requested a review from mmalerba as a code owner April 16, 2022 08:01
@andrewseguin
Copy link
Contributor

Yeah, in order for the tests to pass here we'll need this merged into the MDC side. I'll try to work internally help speed this up if it isn't looked at this week

@volvachev
Copy link
Contributor Author

Yeah, in order for the tests to pass here we'll need this merged into the MDC side. I'll try to work internally help speed this up if it isn't looked at this week

Hi, is there any progress with review of my PR in the MDC?

@andrewseguin
Copy link
Contributor

Unfortunately not =\

@devversion devversion removed their request for review August 2, 2022 10:56
@josephperrott josephperrott requested a review from a team as a code owner December 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@mmalerba mmalerba Awaiting requested review from mmalerba

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-selection-list): command + A does not work as a select all.
2 participants
@volvachev @andrewseguin