fix(material/tabs): remove visibility style when hydrating #29220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
fix/adev-api-tabs
branch
from
dfee5f4
to
b5c5bf4
Compare
Closed
JeanMeche
requested review from
amysorto and
wagnermaciel
and removed request for
a team
|
I've added a narrowed down repro: https://github.com/JeanMeche/mat-tabs-prerendering-bug |
andrewseguin
approved these changes
Jun 11, 2024
mmalerba
added
action: merge
This was referenced Jun 24, 2024
Before this commit, when using pre-rendering, the styling animation would only remove the `transform` style when hydrating the component. This commit fixes this by including `visibility` as styles to remove when playing the animations.
JeanMeche
force-pushed
the
fix/adev-api-tabs
branch
from
b5c5bf4
to
3ac82a8
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jul 8, 2024
Before this commit, when using pre-rendering, the styling animation would only remove the `transform` style when hydrating the component. This commit fixes this by including `visibility` as styles to remove when playing the animations. (cherry picked from commit e95d88c)
andrewseguin
pushed a commit
that referenced
this pull request
Jul 8, 2024
Before this commit, when using pre-rendering, the styling animation would only remove the `transform` style when hydrating the component. This commit fixes this by including `visibility` as styles to remove when playing the animations. (cherry picked from commit e95d88c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when using pre-rendering, the styling animation would only remove the
transformstyle when hydrating the component. This commit fixes this by includingvisibilityas styles to remove when playing the animations.Context for this issue is adev: https://angular.dev/api/common/AsyncPipe?tab=usage-notes
As you can see, the tabs doesn't hydrate correctly,
visibility:hiddenon the tab body isn't removed when the animation flushes.I tried the fix in angular/angular#56340
Demo link: https://ng-dev-previews-fw--pr-angular-angular-56340-adev-prev-xdjybnyt.web.app/api/common/AsyncPipe?tab=usage-notes
Edit: narrowed down repro: https://github.com/JeanMeche/mat-tabs-prerendering-bug