Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk/drag-drop): add the ability to specify an alternate drop list container #29283

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

crisbeto
Copy link
Member

Adds the new cdkDropListElementContainer input that allows users to specify a different element that should be considered the root of the drop list. This is useful in the cases where the user might not have full control over the DOM between the drop list and the items, like when making a tab list draggable.

Fixes #29140.

…t container

Adds the new `cdkDropListElementContainer` input that allows users to specify a different element that should be considered the root of the drop list. This is useful in the cases where the user might not have full control over the DOM between the drop list and the items, like when making a tab list draggable.

Fixes angular#29140.
@crisbeto crisbeto added the G This is is related to a Google internal issue label Jun 19, 2024
@crisbeto crisbeto requested a review from a team as a code owner June 19, 2024 09:40
@crisbeto crisbeto requested review from amysorto and mmalerba and removed request for a team June 19, 2024 09:40
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 19, 2024
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Jun 19, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 19, 2024
@crisbeto crisbeto merged commit b5e3015 into angular:main Jun 19, 2024
26 of 29 checks passed
DBowen33 pushed a commit to DBowen33/components that referenced this pull request Jul 3, 2024
…t container (angular#29283)

Adds the new `cdkDropListElementContainer` input that allows users to specify a different element that should be considered the root of the drop list. This is useful in the cases where the user might not have full control over the DOM between the drop list and the items, like when making a tab list draggable.

Fixes angular#29140.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cdkDropList/mat-tab-nav-bar): Wrong container for cdkPlaceHolder/cdkDrag after drag/hover from other list
2 participants