fix(multiple): remove workarounds for formControl directive #29296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
blocked
angular-robot
bot
added
the
area: build & ci
mmalerba
removed
the
blocked
mmalerba
requested review from
crisbeto and
amysorto
and removed request for
a team
angular-robot
bot
removed
the
area: build & ci
andrewseguin
approved these changes
Jun 24, 2024
The formControl directive previously did not mark itself for check, so several components that work closely with this directive marked for check on its behalf as a workaround. Now that the directive is fixed we can remove the workarounds.
crisbeto
approved these changes
Jun 24, 2024
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 3, 2024
…29296) The formControl directive previously did not mark itself for check, so several components that work closely with this directive marked for check on its behalf as a workaround. Now that the directive is fixed we can remove the workarounds.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on #29295