fix(material/chips): remove button is too small #29351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
from
049bd97
to
347ecef
Compare
angular-robot
bot
added
the
detected: breaking change
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
from
24e6edb
to
1319eee
Compare
essjay05
changed the title
essjay05
requested review from
crisbeto and
amysorto
and removed request for
a team
mmalerba
added
the
dev-app preview
mmalerba
reviewed
Jul 1, 2024
|
Deployed dev-app for 1442854 to: https://ng-dev-previews-comp--pr-angular-components-29351-dev-4ylvjidv.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
4 times, most recently
from
3c5e924
to
97aa7b2
Compare
|
As recommended, tested on Mac Chrome and Firefox against React, Vue, W3, and dialog native html. The issue is reproducible in each of these when using a Mac OS. Examples tested: |
mmalerba
reviewed
Jul 10, 2024
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
from
97aa7b2
to
37d6220
Compare
mmalerba
reviewed
Jul 11, 2024
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
2 times, most recently
from
23e354f
to
9c4960c
Compare
Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices. Fixes b/286959517
Fixes lint errors from previous commit for Angular Components Chip component where the remove button touch target is too small, particularly for touch/mobile devices. Increases padding on all sides. Fixes b/286959517
Fixes issue with Angular Component Chip's touch target size by increasing the padding on chips with a trailing icon that has an action. Fixes b/286959517 BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices.
Updates fix to Autocomplete Component Chips component where the touch target size is too small and fails minimum accessibility size of 48x48 px. Addresses nit fixes from PR review. Fixes b/286959517 BREAKING CHANGE: updates padding size of remove touch target to satisfy minimum 48x48 accessibility size.
Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices. Fixes b/286959517
Fixes lint errors from previous commit for Angular Components Chip component where the remove button touch target is too small, particularly for touch/mobile devices. Increases padding on all sides. Fixes b/286959517
Fixes issue with Angular Component Chip's touch target size by increasing the padding on chips with a trailing icon that has an action. Fixes b/286959517 BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices.
…essible Updates Angular Components Chips component by increasing its .mat-mdc-chip-remove::after styles to increase the size of the touch target to make it more accessible/clickable. Fixes b/286959517
Updates fix for Angular Components Chips component where there were lint formatting errors.
Updates previous Angular Components Chip component fix and makes it adaptable by swapping the hard-coded 18px offset to equal the variable for -icon-size.
Updates previous Angular Component Chip component fix which added padding to the ::after pseudo-element and attempted to calculate centering. Changes calculation based on using with padding values countered with margin negative values to center the touch target.
Updates Angular Component Chips component fix to change ::after background property changes to be background-color specifically to avoid overriding background-clip styles. Suppresses lint warning material/no-prefixes for background-clip since it's majority compatible with browsers. Fixes b/286959517
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
from
9c4960c
to
1442854
Compare
|
Looks good! I notice that the chip content seems slightly off center, but that appears to be an issue at HEAD, likely a regression introduced by #29357 and not something blocking for this PR |
mmalerba
approved these changes
Jul 16, 2024
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix(material/chip): remove button is too small Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices. Fixes b/286959517 * refactor(material/chips): remove button is too small Fixes lint errors from previous commit for Angular Components Chip component where the remove button touch target is too small, particularly for touch/mobile devices. Increases padding on all sides. Fixes b/286959517 * fix(material/chips): increase chip remove button touch target size Fixes issue with Angular Component Chip's touch target size by increasing the padding on chips with a trailing icon that has an action. Fixes b/286959517 BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices. * refactor(material/chips): chip remove touch target size is insufficient Updates fix to Autocomplete Component Chips component where the touch target size is too small and fails minimum accessibility size of 48x48 px. Addresses nit fixes from PR review. Fixes b/286959517 BREAKING CHANGE: updates padding size of remove touch target to satisfy minimum 48x48 accessibility size. * fix(material/chip): remove button is too small Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices. Fixes b/286959517 * refactor(material/chips): remove button is too small Fixes lint errors from previous commit for Angular Components Chip component where the remove button touch target is too small, particularly for touch/mobile devices. Increases padding on all sides. Fixes b/286959517 * fix(material/chips): increase chip remove button touch target size Fixes issue with Angular Component Chip's touch target size by increasing the padding on chips with a trailing icon that has an action. Fixes b/286959517 BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices. * fix(material/chips): chips remove touch target is too small to be accessible Updates Angular Components Chips component by increasing its .mat-mdc-chip-remove::after styles to increase the size of the touch target to make it more accessible/clickable. Fixes b/286959517 * refactor(material/chips): fix lint errors Updates fix for Angular Components Chips component where there were lint formatting errors. * refactor(material/chips): replace px with _trailing-icon-size variable Updates previous Angular Components Chip component fix and makes it adaptable by swapping the hard-coded 18px offset to equal the variable for -icon-size. * refactor(material/chips): updates touch target centering method Updates previous Angular Component Chip component fix which added padding to the ::after pseudo-element and attempted to calculate centering. Changes calculation based on using with padding values countered with margin negative values to center the touch target. * refactor(material/chips): updates ::after styles and fix lint errors Updates Angular Component Chips component fix to change ::after background property changes to be background-color specifically to avoid overriding background-clip styles. Suppresses lint warning material/no-prefixes for background-clip since it's majority compatible with browsers. Fixes b/286959517 (cherry picked from commit d6aed80)
andrewseguin
added a commit
to andrewseguin/components
that referenced
this pull request
Jul 17, 2024
This reverts commit d6aed80.
andrewseguin
added a commit
that referenced
this pull request
Jul 17, 2024
andrewseguin
added a commit
that referenced
this pull request
Jul 17, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices.
Fixes b/286959517
Before screenshot
After screenshot
BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices.