Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk/drag-drop): add input to specify dragged item scale #29392

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 7, 2024

In some cases the parent of the dragged element might be scaled (e.g. when implementing zoom) which can throw off the positioning. Detecting this would be expensive, because we'd have to check the entire DOM tree so instead these changes add an input so the user can specify the scale amount.

In some cases the parent of the dragged element might be scaled (e.g. when implementing zoom) which can throw off the positioning. Detecting this would be expensive, because we'd have to check the entire DOM tree so instead these changes add an input so the user can specify the scale amount.
@crisbeto crisbeto added G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release labels Jul 7, 2024
@crisbeto crisbeto requested a review from a team as a code owner July 7, 2024 08:39
@crisbeto crisbeto requested review from amysorto and mmalerba and removed request for a team July 7, 2024 08:39
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jul 7, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 8, 2024
@crisbeto crisbeto removed request for amysorto and mmalerba July 8, 2024 16:46
@crisbeto crisbeto merged commit b2c051d into angular:main Jul 8, 2024
26 of 29 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants