fix(material/chips): increase chip remove touch target size #29452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
mmalerba and
andrewseguin
and removed request for
a team
mmalerba
approved these changes
Jul 17, 2024
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
2 times, most recently
from
de46773
to
2d4f46d
Compare
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
2 times, most recently
from
fe09934
to
138bba0
Compare
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
3 times, most recently
from
1e81412
to
b6b30ad
Compare
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
2 times, most recently
from
1183951
to
ad1bd30
Compare
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
6 times, most recently
from
5ff96b3
to
9d61337
Compare
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
3 times, most recently
from
e4cf68e
to
63f0f84
Compare
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
3 times, most recently
from
ef073d2
to
8bfdcb6
Compare
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
2 times, most recently
from
8640b14
to
f8f9a43
Compare
Fixes Angular Components Chips component accessibility issue where the touch target is too small. Updates the chips' remove button ::after margin and padding styles to create a larger touch target to meet the minimum 48px x 48px size. Fixes b/286959517
Updates previous fix to correct lint error due to changing some lines from background to targeting background-color specifically.
essjay05
force-pushed
the
fix-increase-chip-remove-touch-target
branch
from
f8f9a43
to
3d3a659
Compare
andrewseguin
added
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Sep 18, 2024
* fix(material/chips): increase chip remove touch target size Fixes Angular Components Chips component accessibility issue where the touch target is too small. Updates the chips' remove button ::after margin and padding styles to create a larger touch target to meet the minimum 48px x 48px size. Fixes b/286959517 * refactor(material/chips): fix lint errors Updates previous fix to correct lint error due to changing some lines from background to targeting background-color specifically. (cherry picked from commit 777d1d2)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Angular Components Chips component accessibility issue where the touch target is too small. Updates the chips' remove button ::after margin and padding styles to create a larger touch target to meet the minimum 48px x 48px size.
Before screenshot
After screenshot
Fixes b/286959517