-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/slide-toggle): don't trigger active state for entire container #29514
Merged
crisbeto
merged 1 commit into
angular:main
from
crisbeto:29483/slide-toggle-clickable-area
Jul 30, 2024
Merged
fix(material/slide-toggle): don't trigger active state for entire container #29514
crisbeto
merged 1 commit into
angular:main
from
crisbeto:29483/slide-toggle-clickable-area
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto and
mmalerba
and removed request for
a team
July 30, 2024 07:44
crisbeto
force-pushed
the
29483/slide-toggle-clickable-area
branch
2 times, most recently
from
July 30, 2024 12:11
df76492
to
c42022b
Compare
…tainer Fixes that the slide toggle was triggering the `:active` styles for the entire container, even though only parts of it are interactive. Fixes angular#29483.
crisbeto
force-pushed
the
29483/slide-toggle-clickable-area
branch
from
July 30, 2024 12:38
c42022b
to
4da0ca1
Compare
crisbeto
changed the title
fix(material/slide-toggle): increase clickable area
fix(material/slide-toggle): don't trigger active state for entire container
Jul 30, 2024
amysorto
approved these changes
Jul 30, 2024
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the slide toggle was triggering the
:active
styles for the entire container, even though only parts of it are interactive.Fixes #29483.