Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove compileComponent calls #29535

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 2, 2024

Calls to compileComponent aren't necessary in the vast majority of cases. These changes clean them up from our codebase.

Calls to `compileComponent` aren't necessary in the vast majority of cases. These changes clean them up frm our codebase.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 2, 2024
@crisbeto crisbeto marked this pull request as ready for review August 2, 2024 07:38
@crisbeto crisbeto requested a review from a team as a code owner August 2, 2024 07:38
@crisbeto crisbeto requested review from amysorto, wagnermaciel and andrewseguin and removed request for a team August 2, 2024 07:38
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 6, 2024
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 6, 2024
@crisbeto crisbeto merged commit 4718718 into angular:main Aug 6, 2024
26 of 28 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants