Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk/a11y): use native media query for high contrast detection #29678

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 2, 2024

Changes the cdk.high-contrast mixin to use a native media query instead of a custom CSS classes. The advantage is that we no longer need to depend on the HighContrastModeDetector to add a class that we can target.

BREAKING CHANGE:

  • Since cdk.high-contrast targets a media query instead of a class, the specificity of the styles it emits is lower than before.

Changes the `cdk.high-contrast` mixin to use a native media query instead of a custom CSS classes. The advantage is that we no longer need to depend on the `HighContrastModeDetector` to add a class that we can target.

BREAKING CHANGE:
* Since `cdk.high-contrast` targets a media query instead of a class, the specificity of the styles it emits is lower than before.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: major This PR is targeted for the next major release labels Sep 2, 2024
@crisbeto crisbeto requested a review from a team as a code owner September 2, 2024 09:06
@crisbeto crisbeto requested review from amysorto and wagnermaciel and removed request for a team September 2, 2024 09:06
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit labels Sep 2, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2024
@crisbeto crisbeto merged commit f4a02ad into angular:main Sep 3, 2024
29 of 31 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants