Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): replace labels not pointing to anything #29755

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

crisbeto
Copy link
Member

Fixes that the datepicker had some <label> elements that weren't pointing to anything via the for attribute which was being flagged by Chrome.

Fixes #29749.

Fixes that the datepicker had some `<label>` elements that weren't pointing to anything via the `for` attribute which was being flagged by Chrome.

Fixes angular#29749.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 18, 2024
@crisbeto crisbeto requested a review from a team as a code owner September 18, 2024 08:57
@crisbeto crisbeto requested review from amysorto and mmalerba and removed request for a team September 18, 2024 08:57
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2024
@crisbeto crisbeto merged commit 602bef1 into angular:main Sep 18, 2024
22 of 25 checks passed
crisbeto added a commit that referenced this pull request Sep 18, 2024
…9755)

Fixes that the datepicker had some `<label>` elements that weren't pointing to anything via the `for` attribute which was being flagged by Chrome.

Fixes #29749.

(cherry picked from commit 602bef1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(material/datepicker): Chrome; A <label> isn't associated with a form field
2 participants