Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cdk/tree): fix several live example issues #29875

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

crisbeto
Copy link
Member

Fixes the following issues with the tree live examples:

  • Both the tree node and the toggle were marked as toggles which meant that clicking anywhere would close the tree.
  • The toggles weren't centered relative to the text.
  • A couple of examples had the same name and one had weird punctuation.

Fixes #29830.

Fixes the following issues with the tree live examples:
* Both the tree node and the toggle were marked as toggles which meant that clicking anywhere would close the tree.
* The toggles weren't centered relative to the text.
* A couple of examples had the same name and one had weird punctuation.

Fixes angular#29830.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 14, 2024
@crisbeto crisbeto requested a review from a team as a code owner October 14, 2024 07:10
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team October 14, 2024 07:10
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 14, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2024
@crisbeto crisbeto merged commit 52cad9c into angular:main Oct 14, 2024
27 checks passed
crisbeto added a commit that referenced this pull request Oct 14, 2024
Fixes the following issues with the tree live examples:
* Both the tree node and the toggle were marked as toggles which meant that clicking anywhere would close the tree.
* The toggles weren't centered relative to the text.
* A couple of examples had the same name and one had weird punctuation.

Fixes #29830.

(cherry picked from commit 52cad9c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(CdkTree): Clicking on nested tree nodes collapses parent tree node
2 participants