fix(cdk/table): run differ for all columns #30012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
amysorto,
wagnermaciel and
crisbeto
and removed request for
a team
andrewseguin
added
the
target: patch
crisbeto
approved these changes
Nov 14, 2024
andrewseguin
added a commit
that referenced
this pull request
Nov 14, 2024
* fix(cdk/table): run differ for all columns * fix(cdk/table): include comment --------- Co-authored-by: Andrew Seguin <andrewseguin@google.com> (cherry picked from commit f1c4173)
andrewseguin
added a commit
that referenced
this pull request
Nov 14, 2024
* fix(cdk/table): run differ for all columns * fix(cdk/table): include comment --------- Co-authored-by: Andrew Seguin <andrewseguin@google.com> (cherry picked from commit f1c4173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloned from original author's change but is failing CLA #29922
This ensures the differ is run without short-circuiting and skipping columns, which is apparently important for change detection reasons
Fixes #29922