Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/timepicker): make disabled input public #30063

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

crisbeto
Copy link
Member

Initially the disabled input was marked as protected, because the actual disabled state is a computed. This seems to break with some compiler options so these changes switches it to be public.

Fixes #30061.

Initially the `disabled` input was marked as `protected`, because the actual disabled state is a `computed`. This seems to break with some compiler options so these changes switches it to be public.

Fixes angular#30061.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 22, 2024
@crisbeto crisbeto requested a review from devversion November 22, 2024 08:01
@crisbeto crisbeto requested a review from a team as a code owner November 22, 2024 08:01
@crisbeto crisbeto requested review from mmalerba and removed request for a team November 22, 2024 08:01
@crisbeto crisbeto removed the request for review from mmalerba November 22, 2024 11:25
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 22, 2024
@crisbeto crisbeto merged commit d6b3775 into angular:main Nov 22, 2024
26 checks passed
crisbeto added a commit that referenced this pull request Nov 22, 2024
Initially the `disabled` input was marked as `protected`, because the actual disabled state is a `computed`. This seems to break with some compiler options so these changes switches it to be public.

Fixes #30061.

(cherry picked from commit d6b3775)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/timepicker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(timepicker): cannot disable timepicker from template
2 participants