fix(material/menu): remove dependency on animations module #30099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the menu so it no longer depends on the animations module. This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
Totati
reviewed
Nov 28, 2024
| @@ -85,15 +84,15 @@ export class MatMenuContent implements OnDestroy { | |||
| // it needs to check for new menu items and update the `@ContentChild` in `MatMenu`. | |||
| this._changeDetectorRef.markForCheck(); | |||
| this._portal.attach(this._outlet, context); | |||
| this._attached.next(); | |||
| this._attachCount++; | |||
There was a problem hiding this comment.
Seems like you jut increase this counter, but never decrease it.
There was a problem hiding this comment.
It's intentional, because if the content gets detached and re-attached to a different panel, it'll stay at 1.
|
Will pause this for now. It ended up being a bit tricky to land, because there's a lot of the menu lifecycle that's tied to the animations. Also there was an error being thrown when hovering quickly over the nested menu items in the demo. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 11, 2024
Second attempt at reworking the menu so it no longer depends on the animations module (after angular#30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 11, 2024
Second attempt at reworking the menu so it no longer depends on the animations module (after angular#30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 11, 2024
Second attempt at reworking the menu so it no longer depends on the animations module (after angular#30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.
crisbeto
added a commit
that referenced
this pull request
Dec 13, 2024
Second attempt at reworking the menu so it no longer depends on the animations module (after #30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the menu so it no longer depends on the animations module. This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.