Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/button-toggle): unable to tab into ngModel-based group on first render #30103

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

crisbeto
Copy link
Member

Fixes an issue where the button toggle group would reset all the buttons back to tabindex="-1" if they're all static (e.g. not in a loop) and none of them match the value.

Fixes #30097.

…n first render

Fixes an issue where the button toggle group would reset all the buttons back to `tabindex="-1"` if they're all static (e.g. not in a loop) and none of them match the value.

Fixes angular#30097.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 29, 2024
@crisbeto crisbeto requested a review from a team as a code owner November 29, 2024 11:42
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team November 29, 2024 11:42
@crisbeto crisbeto removed the request for review from amysorto December 2, 2024 07:37
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 2, 2024
@crisbeto crisbeto merged commit f0a767c into angular:main Dec 2, 2024
23 of 26 checks passed
crisbeto added a commit that referenced this pull request Dec 2, 2024
…n first render (#30103)

Fixes an issue where the button toggle group would reset all the buttons back to `tabindex="-1"` if they're all static (e.g. not in a loop) and none of them match the value.

Fixes #30097.

(cherry picked from commit f0a767c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/button-toggle target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Button Toggle): Template-driven form not focusable
2 participants