Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(material/theming): fix typo in custom theme guide #30202

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

num13ru
Copy link
Contributor

@num13ru num13ru commented Dec 18, 2024

Summary:

This PR fixes a syntax error in the usage of the mat.theme mixin in the SCSS files of the project. The error occurred due to incorrect wrapping of the Sass map passed as an argument to the mat.theme mixin. Specifically, the map was not correctly enclosed in an additional pair of parentheses, leading to a compilation error.

✘ [ERROR] expected ")".
   ╷
36 │         color: (

Fix:

  • Wrapped the theme configuration map inside an additional set of parentheses for proper syntax in the @include mat.theme() function.

@num13ru num13ru requested a review from a team as a code owner December 18, 2024 11:02
@num13ru num13ru requested review from crisbeto and wagnermaciel and removed request for a team December 18, 2024 11:02
Copy link

google-cla bot commented Dec 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Dec 18, 2024
@crisbeto crisbeto removed the request for review from wagnermaciel December 18, 2024 14:05
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Dec 18, 2024
@crisbeto crisbeto merged commit 8921d07 into angular:main Dec 18, 2024
22 of 24 checks passed
crisbeto pushed a commit that referenced this pull request Dec 18, 2024
@num13ru num13ru deleted the fix-theme-color-docs branch December 23, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants