feat(tabs): adds focus/select events #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
|
||
| /** Used to generate unique ID's for each tab component */ | ||
| let nextId = 0; | ||
|
|
||
| /** A simple change event emitted on focus or selection changes. */ | ||
| export class MdTabEvent { | ||
| index: number; |
There was a problem hiding this comment.
Probably include a reference to the MdTab instance itself
|
@jelbourn Addressed comments |
|
LGTM |
|
How to emit the selectChange Event for "md-tab-link" ? Because with that approach, the slide animation is lost. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #569
R: @jelbourn
I wasn't completely sure what to include in the event, so let me know if there's anything else I should include there.