-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes to a11y errors #654
fixes to a11y errors #654
Conversation
@@ -1,6 +1,6 @@ | |||
<!doctype html> | |||
{{!-- This file is an handlebar file that gets filled at build time. --}} | |||
<html> | |||
<html lang="en"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to apply this to the e2e-app
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertmesserle is doing this in #650
@@ -11,8 +11,8 @@ | |||
</section> | |||
|
|||
<section> | |||
<a href="http://www.google.com" md-button color="primary">link</a> | |||
<a href="http://www.google.com" md-raised-button>link</a> | |||
<a href="http://www.google.com" md-button color="primary">Google</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text should be "SEARCH"
Closed in favor of #741 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This fixes 2 a11y errors.