Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): only fires one click event per click #664

Closed
wants to merge 1 commit into from
Closed

fix(checkbox): only fires one click event per click #664

wants to merge 1 commit into from

Conversation

robertmesserle
Copy link
Contributor

closes #651
R: @jelbourn

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement labels Jun 9, 2016
@jelbourn
Copy link
Member

@robertmesserle Seems to fail on IE11, Edge, and iOS Safari.

Can you add an explanation for what's going on here both in the PR and in comments in the code?

@jelbourn
Copy link
Member

There's an other PR #613 for this; does changing the event to just click solve this problem?

@robertmesserle
Copy link
Contributor Author

Hm, it might - I was mostly re-adding what I had removed from checkboxes
during the refactor, but if that works, that's even better!

On Fri, Jun 10, 2016 at 10:24 AM, Jeremy Elbourn notifications@github.com
wrote:

There's an other PR #613 #613
for this; does changing the event to just click solve this problem?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#664 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAi346PZJdiFBbEhddmEtfVOgP-wltsGks5qKZ3igaJpZM4Iyey8
.

@robertmesserle
Copy link
Contributor Author

@jelbourn We should use #613 for this

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MdCheckbox fires a click event twice
3 participants