update(): prevent change event to be fired at initialization #713
Conversation
… multiple times * Adds a test which confirms, that the slide-toggle isn't firing the (change) event multiple times. Closes angular#709
googlebot
added
the
cla: yes
devversion
changed the title
| @@ -74,6 +76,14 @@ export class MdSlideToggle implements ControlValueAccessor { | |||
| private _renderer: Renderer) { | |||
| } | |||
|
|
|||
| /** @internal */ | |||
There was a problem hiding this comment.
We figured out in alpha.5 that we can't actually mark life-cycle events as @internal, since they then no longer satisfy the corresponding interface when compiled downstream. So I've been doing TODO: internal for when TS adds a first class internal access modifier.
There was a problem hiding this comment.
Ah right, I've heard about that in another issue, but I missed that. Thanks again for the clarification, that makes sense.
|
LGTM aside from that |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #709