Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(menu): add keyboard events and accessibility #937

Closed
wants to merge 1 commit into from
Closed

feat(menu): add keyboard events and accessibility #937

wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Jul 30, 2016

This PR adds keyboard events and proper focus management to the menu.

r: @jelbourn

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2016
jelbourn
jelbourn reviewed Jul 31, 2016
View reviewed changes
src/components/menu/README.md
#### Keyboard events:
- DOWN_ARROW or TAB: Focus next menu item
- UP_ARROW or SHIFT_TAB: Focus previous menu item
- ENTER: Select focused item
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use markdown for keyboard shortcuts like this
Enter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way! Can update.

@kara kara changed the title feat(forms): add keyboard events and accessibility feat(menu): add keyboard events and accessibility Jul 31, 2016
@kara
Copy link
Contributor Author

kara commented Jul 31, 2016

@jelbourn Comments should be addressed

@kara kara added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed pr: needs review labels Aug 8, 2016
@kara
Copy link
Contributor Author

kara commented Aug 8, 2016

This PR is blocked on speeding up our e2e tests (which is blocked on build config changes).

@kara
Copy link
Contributor Author

kara commented Aug 30, 2016

Closing in favor of #1132

@kara kara closed this Aug 30, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jelbourn jelbourn

Labels
blocked This issue is blocked by some external factor, such as a prerequisite PR cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kara @jelbourn @googlebot