fix(mdMenu): close on scope $destroy

closes #3189
angular · Jun 11, 2015 · 67be5ce · 67be5ce
1 parent 94b03b0
commit 67be5ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/components/menu/_menu.js b/src/components/menu/_menu.js
@@ -162,6 +162,13 @@ function MenuDirective($mdMenu) {
     menuContainer.append(menuContents);
     mdMenuCtrl.init(menuContainer);
 
+    scope.$on('$destroy', function() {
+      if (mdMenuCtrl.isOpen) {
+        menuContainer.remove();
+        mdMenuCtrl.close();
+      }
+    });
+
   }
 }
 
@@ -178,6 +185,7 @@ function MenuController($mdMenu, $attrs, $element, $scope) {
 
   // Uses the $mdMenu interim element service to open the menu contents
   this.open = function openMenu() {
+    ctrl.isOpen = true;
     $element.attr('aria-expanded', 'true');
     $mdMenu.show({
       mdMenuCtrl: ctrl,
@@ -190,6 +198,7 @@ function MenuController($mdMenu, $attrs, $element, $scope) {
 
   // Use the $mdMenu interim element service to close the menu contents
   this.close = function closeMenu(skipFocus) {
+    ctrl.isOpen = false;
     $element.attr('aria-expanded', 'false');
     $mdMenu.hide();
 

diff --git a/src/components/menu/menu-interim-element.js b/src/components/menu/menu-interim-element.js
@@ -244,7 +244,6 @@ function MenuProvider($$interimElementProvider) {
      * @param {object} opts - the interim element options object
      */
     function positionMenu(el, opts) {
-      debugger;
       if (opts.isRemoved) return;
 
       var containerNode = el[0],