Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fab speed dial cannot be hided using ng-hide #3313

Closed
xforceco opened this issue Jun 17, 2015 · 2 comments
Closed

fab speed dial cannot be hided using ng-hide #3313

xforceco opened this issue Jun 17, 2015 · 2 comments
Assignees
@topherfangio
Labels
resolution: fixed
Milestone
0.10.1

Comments

@xforceco
Copy link

When the dial is in open state, I trigger a variable to make expression in ng-hide = true, in an attempt to hide it but fails.
pr2
@jameswyse
Copy link

Looks like the ng-hide-animate class isn't being removed after the animation.

@topherfangio topherfangio self-assigned this Jun 23, 2015
@topherfangio
Copy link
Contributor

Thanks guys, I'll take a look :-)

topherfangio added a commit that referenced this issue Jun 28, 2015
@topherfangio
fix(fabSpeedDial): fix ability to use ng-hide
37cfe91 
the animations were not properly calling the `done()` callback, so
the `ng-animate` class was never being removed

closes #3313
@ThomasBurleson ThomasBurleson modified the milestone: 0.10.1 Jun 30, 2015
topherfangio added a commit that referenced this issue Jul 5, 2015
@topherfangio
fix(fabSpeedDial): fix ability to use ng-hide
06b2e77 
the animations were not properly calling the `done()` callback, so
the `ng-animate` class was never being removed

closes #3313
topherfangio added a commit that referenced this issue Jul 6, 2015
@topherfangio
fix(fabSpeedDial): ng-hide, ng-repeat, animation bug
544381d 
 * fixes ability to use ng-hide: the animations were not properly
   calling the `done()` callback, so the `ng-animate` class was
   never being removed

 * you can now use ng-repeat for the speed dial's action items
   also updated docs to have fewer but more complex examples

 * the speed dial was not properly initializing it's transforms,
   so the first time it was opened, it would not animate properly

closes #3313, closes #3224, closes #3349
@topherfangio topherfangio mentioned this issue Jul 6, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topherfangio topherfangio

Labels
resolution: fixed
Projects
None yet
Milestone
0.10.1
Development

Successfully merging a pull request may close this issue.

fix(fabSpeedDial): ng-hide, ng-repeat, animation bug angular/material
4 participants
@topherfangio @ThomasBurleson @jameswyse @xforceco