Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

feat(sidenav): add swipe functionality #35

Open
Urigo opened this issue Jul 3, 2014 · 51 comments
Open

feat(sidenav): add swipe functionality #35

Urigo opened this issue Jul 3, 2014 · 51 comments
Labels
- Lots of Comments Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. P2: required Issues that must be fixed. type: enhancement type: gestures
Milestone

Comments

@Urigo
Copy link

Urigo commented Jul 3, 2014

Add the same swipe functionality behavior as ion-side-menus to open sidenav not just with click but with swipe left (or right)

Awesome work!

@ThomasBurleson ThomasBurleson added this to the 0.0.6 milestone Aug 27, 2014
@ThomasBurleson ThomasBurleson modified the milestones: 0.0.5, 0.0.6 Sep 29, 2014
@gkalpak
Copy link
Member

gkalpak commented Dec 4, 2014

@ThomasBurleson: Same story here :) What does closing this ticket mean ?

@ThomasBurleson ThomasBurleson changed the title Adding swipe functionality to sidenav mdSideNav: Adding swipe functionality Dec 4, 2014
@ThomasBurleson ThomasBurleson changed the title mdSideNav: Adding swipe functionality mdSideNav: adding swipe functionality Dec 4, 2014
@plato-cambrian
Copy link

+1

@EladBezalel
Copy link
Member

as @gkalpak said, What does closing this ticket mean? still there's no support.

@ThomasBurleson
Copy link
Contributor

@EladBezalel, @gkalpak - I cannot recall the reason why this was closed (and I obviously did not provide a comment). I will reopen until the pending Gestures features are pushed to master.

@gustavohenke
Copy link

@ThomasBurleson I've been using md-swipe-right="$mdSidenav( 'sidenav' ).open()" (and the opposite) with no problems at all.
What I did can be considered an workaround?

@EladBezalel
Copy link
Member

Its workaround but you would expect it to react with your finger..
Also i don't want to put md-swipe-right="$mdSidenav( 'sidenav' ).open() on my body or container div

@atentis
Copy link

atentis commented Jan 6, 2015

+1

It would be fantastic if the swipe functionality could be added to close the side menu!

Thanks!

@Splaktar
Copy link
Member

Splaktar commented Mar 7, 2015

@ThomasBurleson This is scheduled for 0.5 but is still open. Should this be rescheduled to 0.9.0 or 0.10.0?

@mathiasmoeller
Copy link

+1

@nikopolv
Copy link

We really need this. +1

@asoseil
Copy link

asoseil commented Apr 14, 2015

+1

@atentis
Copy link

atentis commented Apr 15, 2015

@ThomasBurleson @ajoslin Will this be in 0.9?

@ThomasBurleson ThomasBurleson modified the milestones: Deprecated, Backlog Apr 21, 2016
@marco-silva0000
Copy link

what is the status of this?

@EladBezalel
Copy link
Member

This issue has been deprecated, although we do have an effort improving our gestures service with hammer.js, after that will go in we can easily enough make sidenav with dragging support.

@amritk
Copy link

amritk commented Aug 30, 2016

If anyone wants to do one themselves without hammer.js you can check out this vid:
https://www.youtube.com/watch?v=Mhnj3PiPnZw

@seb777
Copy link

seb777 commented Mar 29, 2018

@marekmicek +1

@Splaktar Splaktar changed the title mdSideNav: adding swipe functionality feat(sidenav): add swipe functionality Mar 29, 2018
@Splaktar Splaktar added for: external contributor P2: required Issues that must be fixed. and removed pr: merge ready This PR is ready for a caretaker to review labels Mar 29, 2018
@Splaktar Splaktar modified the milestones: Deprecated, 1.1.9 Mar 29, 2018
@Splaktar
Copy link
Member

This feature has been a very hot request from the community for years now. However, we've never (to my knowledge) had a community PR to add this functionality. I am reopening this so that the community knows that we would welcome a quality PR that adds this functionality. While you can't just copy #6174, you could review it for some of the issues already encountered.

Note that there are no plans at this time for the AngularJS Material team to implement this feature.

@Splaktar Splaktar reopened this Mar 29, 2018
@Splaktar Splaktar modified the milestones: 1.1.9, 1.1.10 Mar 29, 2018
@chenlijun99
Copy link
Contributor

chenlijun99 commented Mar 31, 2018

@Splaktar Must we use $mdGesture to implement this functionality?
I'm trying the implement this with $mdGesture but I encountered some problems.
See #11204

@Splaktar
Copy link
Member

Splaktar commented Apr 5, 2018

@Free-Easy That would be the preferred approach as introducing something like hammerjs at this point is probably not a good idea. Thanks for opening that issue.

@Splaktar Splaktar added the Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. label Apr 5, 2018
@Splaktar Splaktar modified the milestones: 1.1.10, - Backlog Apr 5, 2018
@Splaktar
Copy link
Member

Splaktar commented Apr 5, 2018

Oh, it does look like we have an issue open to move over to hammerjs and get rid of $mdGesture. However, I'm not sure that will ever happen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- Lots of Comments Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. P2: required Issues that must be fixed. type: enhancement type: gestures
Projects
None yet
Development

No branches or pull requests